daniel/danos
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

device-manager: the entries-per-reply test asserts 7 (the current shape), not 10

Browse Source 
A pre-existing stale assertion, surfaced by wiring volume-manager into the root
test aggregate (its partition fixtures now run under `zig build test`).
entries_per_reply is computed as (packet_maximum 256 - prefix 16) / sizeof
ChildEntry 32 = 7; the test asserted 10, the value the old count-header layout
carried. No behavior change — the enumerate producer and consumers already page
by the real capacity; only the test documented an obsolete number.
This commit is contained in:
Daniel Samson
2026-08-09 23:26:12 +01:00
parent 48ab12e262
commit 5637d0e5fc
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
library/protocol/device-manager/device-manager-protocol.zig
+3 -2
View File
@@ -212,8 +212,9 @@ test "a tree report fits the push floor with the header folded in" {
try std.testing.expectEqual(@as(usize, 48), @sizeOf(ChildAdded)); try std.testing.expectEqual(@as(usize, 48), @sizeOf(ChildAdded));
try std.testing.expectEqual(envelope.post_maximum, Protocol.event_maximum); try std.testing.expectEqual(envelope.post_maximum, Protocol.event_maximum);
try std.testing.expect(Protocol.event_maximum <= envelope.post_maximum); try std.testing.expect(Protocol.event_maximum <= envelope.post_maximum);
// Ten records per enumerate reply — what the old count-header layout carried. // Seven records per enumerate reply: (packet_maximum 256 - prefix 16) / 32.
try std.testing.expectEqual(@as(usize, 10), entries_per_reply); // (The old count-header layout carried ten; this asserts the current shape.)
try std.testing.expectEqual(@as(usize, 7), entries_per_reply);
} }
test "the verb and event numbering, and the device id in the header" { test "the verb and event numbering, and the device id in the header" {